kvserver: setup ranges in large unsplittable replicate test #112990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
changed the title
This was referenced Oct 24, 2023
|
Essential CI failure unrelated, I'll rebase later. |
kvoli
force-pushed
the
231024.deflake-large-unsplittable
branch
from
e6bd351
to
6fab2c5
Compare
kvoli
commented
Oct 24, 2023
| @@ -1774,8 +1774,6 @@ func TestLargeUnsplittableRangeReplicate(t *testing.T) { | |||
| base.TestClusterArgs{ | |||
| ReplicationMode: base.ReplicationAuto, | |||
| ServerArgs: base.TestServerArgs{ | |||
| ScanMinIdleTime: time.Millisecond, | |||
There was a problem hiding this comment.
This was redundant, the test already force scan & processes every range within the SucceedsSoon loops below.
There was a problem hiding this comment.
In addition to enqueuing on span config updates.
This reverts commit 9d4a50c.
`TestLargeUnsplittableRangeReplicate` would fail when the SQL query to show the table's replicas returned no results for the unsplittable range being tested. No results would be returned when the table split was delayed. Update the test to insert a split at the first row, as well as the existing split at the second row. This avoids the first range starting with 5 replicas and the test's reliance on timely span config splits. Resolves: cockroachdb#112774 Release note: None
kvoli
force-pushed
the
231024.deflake-large-unsplittable
branch
from
6fab2c5
to
ad54149
Compare
kvoli
requested review from
andrewbaptist
and removed request for
andrewbaptist
|
TYFTR bors r=andrewbaptist |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestLargeUnsplittableRangeReplicatewould fail when the SQL query toshow the table's replicas returned no results for the unsplittable range
being tested. No results would be returned when the table split was
delayed.
Update the test to insert a split at the first row, as well as the
existing split at the second row. This avoids the first range starting
with 5 replicas and the test's reliance on timely span config splits.
The previous deflake attempt is reverted.
Resolves: #112774
Release note: None