storage: expose new compaction concurrency env var #113052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jbowens
force-pushed
the
concurrency-env
branch
2 times, most recently
from
11cffb1
to
e11d02d
Compare
Add a new COCKROACH_COMPACTION_CONCURRENCY environment variable to control the maximum number of concurrent compactions that a single store will schedule. This environment variable will supersede the old COCKROACH_ROCKSDB_CONCURRENCY environment variable which was undocumented and was unfortunately named. Epic: none Release note (ops change): Introduced a new documented environment variable that allows an operator to configure the compaction concurrency.
jbowens
force-pushed
the
concurrency-env
branch
from
e11d02d
to
9230393
Compare
|
Nice. |
|
Adding backport-23.2 because we talked about doing this for the 23.2 release. However, this would constitute a feature change and requires an okay from above. |
|
TFTR! bors r=itsbilal |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new COCKROACH_COMPACTION_CONCURRENCY environment variable to control the
maximum number of concurrent compactions that a single store will schedule.
This environment variable will supersede the old COCKROACH_ROCKSDB_CONCURRENCY
environment variable which was undocumented and was unfortunately named.
Epic: none
Release note (ops change): Introduced a new documented environment variable
that allows an operator to configure the compaction concurrency.