Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: storage: expose new compaction concurrency env var #113313

Merged
merged 1 commit into from Nov 3, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 30, 2023

Backport 1/1 commits from #113052 on behalf of @jbowens.

/cc @cockroachdb/release


Add a new COCKROACH_COMPACTION_CONCURRENCY environment variable to control the
maximum number of concurrent compactions that a single store will schedule.
This environment variable will supersede the old COCKROACH_ROCKSDB_CONCURRENCY
environment variable which was undocumented and was unfortunately named.

Epic: none
Release note (ops change): Introduced a new documented environment variable
that allows an operator to configure the compaction concurrency.


Release justification: Small new product addition to allow us to document the compaction concurrency environment variable in 23.2.

Add a new COCKROACH_COMPACTION_CONCURRENCY environment variable to control the
maximum number of concurrent compactions that a single store will schedule.
This environment variable will supersede the old COCKROACH_ROCKSDB_CONCURRENCY
environment variable which was undocumented and was unfortunately named.

Epic: none
Release note (ops change): Introduced a new documented environment variable
that allows an operator to configure the compaction concurrency.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113052 branch from 6df9584 to 178fb56 Compare October 30, 2023 19:47
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 30, 2023 19:47
@blathers-crl blathers-crl bot requested a review from itsbilal October 30, 2023 19:47
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 30, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113052 branch from b96e657 to fd58d65 Compare October 30, 2023 19:47
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav
Copy link
Collaborator

LGTM for EM approval ✅.

Deferring the GitHub approval to the second TL reviewer.

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal and @williamkulju)

@jbowens jbowens merged commit 4d40059 into release-23.2 Nov 3, 2023
5 of 6 checks passed
@jbowens jbowens deleted the blathers/backport-release-23.2-113052 branch November 3, 2023 20:52
@jbowens
Copy link
Collaborator

jbowens commented Nov 3, 2023

TFTR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants