kvserver: fix reproposals test with pipelined writes #113658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: none Release note: none
Epic: none Release note: none
Before this commit, the test was a no-op reporting 0 metrics. This is due to isOurCommand function which assumed that the key increment request is always the first request in BatchRequest. With pipelined writes, this is not true. A typical request is: QueryIntent ["00001-testing",/Min), Increment ["00001-testing",/Min) In this commit, isOutCommand scans the BatchRequest to find the command. Before: ``` observed 0 async write restarts, observed 0/0 injected aborts, 0 injected illegal lease applied indexes commands reproposed (unchanged): 1 commands reproposed (new LAI): 0 ``` After: ``` observed 69 async write restarts, observed 0/69 injected aborts, 366 injected illegal lease applied indexes commands reproposed (unchanged): 1 commands reproposed (new LAI): 297 ``` Epic: none Release note: none
|
This change is |
pav-kv
commented
Nov 2, 2023
Epic: none Release note: none
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the test was a no-op reporting 0 metrics. This is due to
isOurCommandfunction which assumed that the key increment request is always the first request inBatchRequest. With pipelined writes, this is not true.A typical request is:
In this commit,
isOutCommandscans theBatchRequestto find the command.Before:
After:
Fixes #106504
Touches #110551
Epic: none
Release note: none