-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: kvserver: fix reproposals test with pipelined writes #113769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: none Release note: none
Epic: none Release note: none
Before this commit, the test was a no-op reporting 0 metrics. This is due to isOurCommand function which assumed that the key increment request is always the first request in BatchRequest. With pipelined writes, this is not true. A typical request is: QueryIntent ["00001-testing",/Min), Increment ["00001-testing",/Min) In this commit, isOutCommand scans the BatchRequest to find the command. Before: ``` observed 0 async write restarts, observed 0/0 injected aborts, 0 injected illegal lease applied indexes commands reproposed (unchanged): 1 commands reproposed (new LAI): 0 ``` After: ``` observed 69 async write restarts, observed 0/69 injected aborts, 366 injected illegal lease applied indexes commands reproposed (unchanged): 1 commands reproposed (new LAI): 297 ``` Epic: none Release note: none
Epic: none Release note: none
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-113658
branch
from
November 3, 2023 18:07
1d00234
to
537047c
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Nov 3, 2023
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-113658
branch
from
November 3, 2023 18:07
b506fe6
to
f06aa83
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Nov 3, 2023
erikgrinaker
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4/4 commits from #113658 on behalf of @pavelkalinnikov.
/cc @cockroachdb/release
Before this commit, the test was a no-op reporting 0 metrics. This is due to
isOurCommand
function which assumed that the key increment request is always the first request inBatchRequest
. With pipelined writes, this is not true.A typical request is:
In this commit,
isOutCommand
scans theBatchRequest
to find the command.Before:
After:
Fixes #106504
Touches #110551
Epic: none
Release note: none
Release justification: fixed test