Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: kvserver: fix reproposals test with pipelined writes #113769

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 3, 2023

Backport 4/4 commits from #113658 on behalf of @pavelkalinnikov.

/cc @cockroachdb/release


Before this commit, the test was a no-op reporting 0 metrics. This is due to isOurCommand function which assumed that the key increment request is always the first request in BatchRequest. With pipelined writes, this is not true.

A typical request is:

QueryIntent ["00001-testing",/Min), Increment ["00001-testing",/Min)

In this commit, isOutCommand scans the BatchRequest to find the command.

Before:

observed 0 async write restarts, observed 0/0 injected aborts, 0 injected illegal lease applied indexes
commands reproposed (unchanged): 1
commands reproposed (new LAI): 0

After:

observed 69 async write restarts, observed 0/69 injected aborts, 366 injected illegal lease applied indexes
commands reproposed (unchanged): 1
commands reproposed (new LAI): 297

Fixes #106504
Touches #110551
Epic: none
Release note: none


Release justification: fixed test

Epic: none
Release note: none
Before this commit, the test was a no-op reporting 0 metrics. This is
due to isOurCommand function which assumed that the key increment
request is always the first request in BatchRequest. With pipelined
writes, this is not true.

A typical request is:
  QueryIntent ["00001-testing",/Min), Increment ["00001-testing",/Min)

In this commit, isOutCommand scans the BatchRequest to find the command.

Before:
```
observed 0 async write restarts, observed 0/0 injected aborts, 0 injected illegal lease applied indexes
commands reproposed (unchanged): 1
commands reproposed (new LAI): 0
```
After:
```
observed 69 async write restarts, observed 0/69 injected aborts, 366 injected illegal lease applied indexes
commands reproposed (unchanged): 1
commands reproposed (new LAI): 297
```

Epic: none
Release note: none
Epic: none
Release note: none
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 3, 2023 18:07
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113658 branch from 1d00234 to 537047c Compare November 3, 2023 18:07
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 3, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113658 branch from b506fe6 to f06aa83 Compare November 3, 2023 18:07
Copy link
Author

blathers-crl bot commented Nov 3, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 3, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv pav-kv merged commit e61e08d into release-23.2 Nov 6, 2023
5 of 6 checks passed
@pav-kv pav-kv deleted the blathers/backport-release-23.2-113658 branch November 6, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants