Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: kvserver: fix reproposals test with pipelined writes #113769

Merged
merged 4 commits into from
Nov 6, 2023

Commits on Nov 2, 2023

  1. kvserver: add missing counter increment

    Epic: none
    Release note: none
    pav-kv committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    85112c0 View commit details
    Browse the repository at this point in the history
  2. kvserver: add metric checks to reproposals test

    Epic: none
    Release note: none
    pav-kv committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cefa999 View commit details
    Browse the repository at this point in the history
  3. kvserver: fix reproposals test with pipelined writes

    Before this commit, the test was a no-op reporting 0 metrics. This is
    due to isOurCommand function which assumed that the key increment
    request is always the first request in BatchRequest. With pipelined
    writes, this is not true.
    
    A typical request is:
      QueryIntent ["00001-testing",/Min), Increment ["00001-testing",/Min)
    
    In this commit, isOutCommand scans the BatchRequest to find the command.
    
    Before:
    ```
    observed 0 async write restarts, observed 0/0 injected aborts, 0 injected illegal lease applied indexes
    commands reproposed (unchanged): 1
    commands reproposed (new LAI): 0
    ```
    After:
    ```
    observed 69 async write restarts, observed 0/69 injected aborts, 366 injected illegal lease applied indexes
    commands reproposed (unchanged): 1
    commands reproposed (new LAI): 297
    ```
    
    Epic: none
    Release note: none
    pav-kv committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1d00234 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. kvserver: use BarchRequest.GetArg

    Epic: none
    Release note: none
    pav-kv committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f06aa83 View commit details
    Browse the repository at this point in the history