team: embed TEAMS.yaml #113835
Merged
team: embed TEAMS.yaml #113835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `internal/team` code looks for `TEAMS.yaml` in the repo. This means that `roachtest` must be run in the tree (and if the branches don't match, obscure errors could happen in principle). This commit moves to embedding the data using `go:embed`. Because `go:embed` doesn't allow embedding of files outside the package, we also have to add a generation rule to copy the file. Fixes: cockroachdb#111661 Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
CC @rickystewart for the bazel which involved a lot of trial-and-error. |
rickystewart
approved these changes
Nov 6, 2023
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
internal/teamcode looks forTEAMS.yamlin the repo. Thismeans that
roachtestmust be run in the tree (and if the branchesdon't match, obscure errors could happen in principle).
This commit moves to embedding the data using
go:embed. Becausego:embeddoesn't allow embedding of files outside the package, wealso have to add a generation rule to copy the file.
Fixes: #111661
Release note: None