New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: sql: fix query start time for begin statements #115259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the query age for BEGIN statements appearing in logs (sql-exec, sql-audit, telemetry) was being incorrectly recorded. This is because the start time being passed was from the stats collector, which was not up to date with the session phase times at the time of executing BEGIN. This patch fixes the query age for BEGIN stmt logs by using the session phase times directly from the conn executor for BEGIN stmt logging instead reading them from the stats collector. Epic: none Fixes: #114571 Release note (bug fix): BEGIN statement logs now have correct query `Age` fields. Previously, these fields were being recorded incorrectly which would lead to some statements also appearing erroneously in the slow query logs.
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-114831
branch
from
November 29, 2023 17:07
c7d1155
to
90923c8
Compare
blathers-crl
bot
requested review from
abarganier
and removed request for
a team
November 29, 2023 17:07
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-114831
branch
from
November 29, 2023 17:07
2356b22
to
3dc6dc5
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Nov 29, 2023
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Nov 29, 2023
rafiss
approved these changes
Nov 30, 2023
dhartunian
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @abarganier and @xinhaoz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #114831 on behalf of @xinhaoz.
/cc @cockroachdb/release
Previously, the query age for BEGIN statements appearing in logs (sql-exec, sql-audit, telemetry) was being incorrectly recorded. This is because the start time being passed was from the stats collector, which was not up to date with the session phase times at the time of executing BEGIN. This patch fixes the query age for BEGIN stmt logs by using the session phase times directly from the conn executor for BEGIN stmt logging instead reading them from the stats collector.
Epic: none
Fixes: #114571
Release note (bug fix): BEGIN statement logs now have correct query
Age
fields. Previously, these fields were being recorded incorrectly which would lead to some statements also appearing erroneously in the slow query logs.Release justification: bug fix GA blocker