Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: sql: fix query start time for begin statements #115259

Merged
merged 1 commit into from Dec 4, 2023

Commits on Nov 21, 2023

  1. sql: fix query start time for begin statements

    Previously, the query age for BEGIN statements appearing in logs
    (sql-exec, sql-audit, telemetry) was being incorrectly recorded.
    This is because the start time being passed was from the stats
    collector, which was not up to date with the session phase times
    at the time of executing BEGIN. This patch fixes the query age
    for BEGIN stmt logs by using the session phase times directly
    from the conn executor for BEGIN stmt logging instead reading
    them from the stats collector.
    
    Epic: none
    Fixes: #114571
    
    Release note (bug fix): BEGIN statement logs now have correct
    query `Age` fields. Previously, these fields were being recorded
    incorrectly which would lead to some statements also appearing
    erroneously in the slow query logs.
    xinhaoz committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3dc6dc5 View commit details
    Browse the repository at this point in the history