workload/schemachange: implement COMMENT ON
#115360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
chrisseto
changed the title
COMMENT ON
chrisseto
force-pushed
the
rsw-comment-on
branch
from
35a921b
to
b20e97b
Compare
This was referenced Dec 19, 2023
chrisseto
requested review from
DarrylWong and
renatolabs
and removed request for
a team
This commit adds support for the `CREATE FUNCTION` DDL to the RSW. While the space for possible UDF incantations is quite large, this commit focused on permutations that are of interest to schema changes. That is to say, the body of the UDF does not have much, if any, variation but will be comprised of references to tables and UDTs. Unfortunately, the introduction of UDFs in the descriptor graph has aggravated an issue within `DROP SCHEMA CASCADE`. This commit contains attempts to correct said issues to no avail. It's possible that either the DSC or LSC are missing some logic for handling UDFs that contain references to UDTs. Prior to this commit, errors preventing the schema from being dropped would be thrown. After it, expected errors are not thrown appropriately despite the checks being hand verified for correctness. Epic: CRDB-19168 Informs: CRDB-3265 Release note: None
This commit adds support for the `DROP FUNCTION` DDL to the RSW. Epic: CRDB-19168 Informs: CRDB-3265
This commit adds support for the `ALTER FUNCTION RENAME TO` and the `ALTER FUNCTION SET SCHEMA` DDLs to the RSW. Other incantations of `ALTER FUNCTION`, namely `OWNER TO` and modifiers, such as `STRICT`, have been omitted as they seem less likely to discover schema related issues. Epic: CRDB-19168 Informs: CRDB-3265 Release note: None
This commit adds support for attaching comments to various schema elements in the RSW. Notably, commenting on databases has been omitted as the workload operates within the scope of a given database. Unfortunately, `COMMENT ON` will consistently trigger the bug reported in cockroachdb#72820. Therefore it is disabled by default. Epic: CRDB-19168 Informs: CRDB-3265 Informs: cockroachdb#72820 Release note: None
chrisseto
force-pushed
the
rsw-comment-on
branch
from
b20e97b
to
be063ef
Compare
craig bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
116790: workload/schemachange: fix `CREATE SCHEMA` for the DSC r=rafiss a=chrisseto ### This PR is stacked on top of others! Please consider reviewing those PRs first. This message will be removed once prerequisite PRs are merged and this one is rebased. * 6e1ea5d is from #115357 * 230b588 is from #115358 * 4cc9b45 is from #115359 * be063ef is from #115360 * 4e89e34 is from #116788 * 95ffcf4 is from #116789 --- #### 89e761126789d2828e141339c34e739203da2310 workload/schemachange: fix `CREATE SCHEMA` for the DSC Previously, `CREATE SCHEMA` would break if executed with the declarative schema changer due to the inclusion of `AUTHORIZATION`. This commit removes the `AUTHORIZATION` clause from `CREATE SCHEMA` operations until it's support within the DSC. Epic: none Release note: None Co-authored-by: Chris Seto <chriskseto@gmail.com>
|
subsumed by #116790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of others!
Please consider reviewing those PRs first. This message will be removed once prerequisite PRs are merged and this one is rebased.
CREATE FUNCTION#115357DROP FUNCTION#115358ALTER FUNCTION#115359be063ef workload/schemachange: implement
COMMENT ONThis commit adds support for attaching comments to various schema
elements in the RSW. Notably, commenting on databases has been omitted
as the workload operates within the scope of a given database.
Unfortunately,
COMMENT ONwill consistently trigger the bug reportedin #72820. Therefore it is disabled by default.
Epic: CRDB-19168
Informs: CRDB-3265
Informs: #72820
Release note: None