Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload/schemachange: enable COMMENT ON #116795

Closed
chrisseto opened this issue Dec 19, 2023 · 1 comment · Fixed by #118861 or #119007
Closed

workload/schemachange: enable COMMENT ON #116795

chrisseto opened this issue Dec 19, 2023 · 1 comment · Fixed by #118861 or #119007
Assignees
@rafiss
Labels
A-random-schema-change-workload C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-schema-testing Originated from SQL Schema testing strategies T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations

Comments

@chrisseto
Copy link
Contributor

chrisseto commented Dec 19, 2023 •
edited by exalate-issue-sync bot

As of #115360, COMMENT ON is support in the RSW but disabled by default due to a known bug: #72820

This is a tracking issue for enabling COMMENT ON after or in tandem with fixing the #72820.

Jira issue: CRDB-34779

Epic CRDB-19168
@chrisseto chrisseto added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) A-random-schema-change-workload O-schema-testing Originated from SQL Schema testing strategies labels Dec 19, 2023
@blathers-crl blathers-crl bot added this to Triage in SQL Foundations Dec 19, 2023
@rafiss rafiss self-assigned this Feb 7, 2024
@rafiss rafiss mentioned this issue Feb 7, 2024
Merged
@craig craig bot closed this as completed in 7074888 Feb 8, 2024
SQL Foundations automation moved this from Triage to Done Feb 8, 2024
This was referenced Feb 8, 2024
Merged
Merged
Merged
@rafiss
Copy link
Collaborator

rafiss commented Feb 8, 2024

re-opening due to #118963

@rafiss rafiss reopened this Feb 8, 2024
SQL Foundations automation moved this from Done to Triage Feb 8, 2024
craig bot pushed a commit that referenced this issue Feb 8, 2024
@rafiss
Merge #118963
6a2e5b1 
118963: Revert "workload/schemachange: re-enable COMMENT in workload" r=rafiss a=rafiss

This reverts commit 60171b4. There are a few flakes should should be resolved first.

informs #116795
fixes #118941
Release note: None

Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@rafiss rafiss mentioned this issue Feb 9, 2024
Merged
@craig craig bot closed this as completed in 5c84682 Feb 9, 2024
SQL Foundations automation moved this from Triage to Done Feb 9, 2024
@rafiss rafiss mentioned this issue Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
A-random-schema-change-workload C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-schema-testing Originated from SQL Schema testing strategies T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations
  
Done
Milestone
No milestone
2 participants
@rafiss @chrisseto