New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: changefeedccl: redact user-sensitive info from SHOW JOBS output #115567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `SHOW CHANGEFEED JOB` revealed sensitive user data like `api_secret` for confluent cloud sinks. This patch now redacts `api_secret`, `sasl_password`, `client_cert`, and `ca_cert` in the job description and sinkURI output column. Fixes: #113503 Release note (enterprise change): SHOW CHANGEFEED JOB, SHOW CHANGEFEED JOBS, and SHOW JOBS no longer expose user sensitive infromation(`api_secret`, `sasl_password`, `client_cert`, and `ca_cert`) in the job description and sinkURI output column would reveal sensitive user information (api_secret, sasl_password, client_cert, ca_cert).
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-115535
branch
from
December 4, 2023 22:09
5b7ff25
to
f67afb2
Compare
blathers-crl
bot
requested review from
jayshrivastava
and removed request for
a team
December 4, 2023 22:09
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Dec 4, 2023
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-115535
branch
from
December 4, 2023 22:09
f7301fc
to
da52700
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Dec 4, 2023
Failure of |
miretskiy
approved these changes
Dec 5, 2023
EM LGTM ✅ |
dt
approved these changes
Dec 6, 2023
TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #115535 on behalf of @wenyihu6.
/cc @cockroachdb/release
Previously,
SHOW CHANGEFEED JOB
revealed sensitive user data likeapi_secret
for confluent cloud sinks. This patch now redacts
api_secret
,sasl_password
,client_cert
, andca_cert
in the job description and sinkURI output column.Fixes: #113503
Release note (enterprise change): SHOW CHANGEFEED JOB, SHOW CHANGEFEED JOBS,
and SHOW JOBS no longer expose user sensitive infromation(
api_secret
,sasl_password
,client_cert
, andca_cert
) in the job description andsinkURI output column would reveal sensitive user information (api_secret,
sasl_password, client_cert, ca_cert).
Release justification: low risk fix for a bug to redact user-sensitive info for SQL output