ui: update label "CPU" to "SQL CPU" #116411
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @florence-crl, @maryliag, and @mgartner)
pkg/ui/workspaces/cluster-ui/src/insights/workloadInsights/util/insightsColumns.tsx line 241 at r1 (raw file):
cpu: (_: InsightExecEnum) => { return makeToolTip( <p>{`SQL CPU Time spent executing within the specified time interval. It
nit: seems like a dangling space at the end.
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/insights/workloadInsights/util/insightsColumns.tsx line 241 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: seems like a dangling space at the end.
fixed
| @@ -238,7 +238,8 @@ export const insightsTableTitles: InsightsTableTitleType = { | |||
| }, | |||
| cpu: (_: InsightExecEnum) => { | |||
| return makeToolTip( | |||
| <p>{`CPU Time spent executing within the specified time interval.`}</p>, | |||
| <p>{`SQL CPU Time spent executing within the specified time interval. It | |||
| excludes the time spent in the KV level as well as SQL planning time.`}</p>, | |||
There was a problem hiding this comment.
Alex's suggestion in slack sounds clearer:
| excludes the time spent in the KV level as well as SQL planning time.`}</p>, | |
| does not include SQL planning time nor KV execution.`}</p>, |
| indicates one standard deviation from the mean. | ||
| Average SQL CPU time spent executing within the specified time | ||
| interval. It excludes the time spent in the KV level as well as | ||
| SQL planning time. The gray bar indicates mean SQL CPU time. The |
There was a problem hiding this comment.
| SQL planning time. The gray bar indicates mean SQL CPU time. The | |
| interval. It does not include SQL planning time nor KV execution | |
| time. The gray bar indicates mean SQL CPU time. The |
Previosuly, we were using the label "CPU Time" in the Console, which could be confusing since it was only SQL CPU Time. This commit updates the title and tooltips to clarify that. Fixes cockroachdb#116409 Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the Console and add clarification to its tooltip.
There was a problem hiding this comment.
Tooltip and images updated! TFTRs!
Will merge once tests pass
Reviewable status:
|
bors r+ |
|
Build succeeded: |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 7f7eda7 to blathers/backport-release-23.1-116411: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. error creating merge commit from 7f7eda7 to blathers/backport-release-23.2-116411: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. error creating merge commit from 7f7eda7 to blathers/backport-release-23.2.0-rc-116411: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.0-rc failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previosuly, we were using the label "CPU Time" in the Console, which could be confusing since it was only SQL CPU Time.
This commit updates the title and tooltips to clarify that.
Fixes #116409
Updates on Insights and SQL Activity pages (Overview, Details, Search Criteria)
Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the Console and add clarification to its tooltip.