Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update "CPU Time" labels to "SQL CPU Time" #116409

Closed
maryliag opened this issue Dec 13, 2023 · 0 comments · Fixed by #116411
Closed

update "CPU Time" labels to "SQL CPU Time" #116409

maryliag opened this issue Dec 13, 2023 · 0 comments · Fixed by #116411
Assignees
@maryliag
Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@maryliag
Copy link
Contributor

maryliag commented Dec 13, 2023 •
edited by cockroach-jira-scripts
Loading

Using the label "CPU Time" can be misleading, since it doesn't include KV and SQL planning time. Update the labels used on the UI and tooltip to clarify that.

Jira issue: CRDB-34613
@maryliag maryliag added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Dec 13, 2023
@maryliag maryliag self-assigned this Dec 13, 2023
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 13, 2023
@maryliag
ui: update label "CPU" to "SQL CPU"
fde5bdd 
Previosuly, we were using the label "CPU Time" in the
Console, which could be confusing since it was only SQL CPU Time.

This commit updates the title and tooltips to clarify that.

Fixes cockroachdb#116409

Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the
Console and add clarification to its tooltip.
@maryliag maryliag mentioned this issue Dec 13, 2023
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 13, 2023
@maryliag
ui: update label "CPU" to "SQL CPU"
96a6fc1 
Previosuly, we were using the label "CPU Time" in the
Console, which could be confusing since it was only SQL CPU Time.

This commit updates the title and tooltips to clarify that.

Fixes cockroachdb#116409

Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the
Console and add clarification to its tooltip.
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 14, 2023
@maryliag
ui: update label "CPU" to "SQL CPU"
7f7eda7 
Previosuly, we were using the label "CPU Time" in the
Console, which could be confusing since it was only SQL CPU Time.

This commit updates the title and tooltips to clarify that.

Fixes cockroachdb#116409

Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the
Console and add clarification to its tooltip.
craig bot pushed a commit that referenced this issue Dec 14, 2023
@maryliag
Merge #116411
25e400f 
116411: ui: update label "CPU" to "SQL CPU" r=maryliag a=maryliag

Previosuly, we were using the label "CPU Time" in the Console, which could be confusing since it was only SQL CPU Time.

This commit updates the title and tooltips to clarify that.

Fixes #116409

Updates on Insights and SQL Activity pages (Overview, Details, Search Criteria)
<img width="1513" alt="Screenshot 2023-12-13 at 7 36 06 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/775801a5-352f-4672-b713-b57a791b6e25">


<img width="1395" alt="Screenshot 2023-12-13 at 7 36 24 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/ce7f32d2-a818-4339-a9d6-4342f496140c">


<img width="801" alt="Screenshot 2023-12-13 at 6 39 51 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/f96d2fa7-0b4d-497c-941a-204665fbce2c">


Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the Console and add clarification to its tooltip.

Co-authored-by: maryliag <marylia@cockroachlabs.com>
@craig craig bot closed this as completed in #116411 Dec 14, 2023
This was referenced Dec 14, 2023
Merged
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 14, 2023
@maryliag
ui: update label "CPU" to "SQL CPU"
440057b 
Previosuly, we were using the label "CPU Time" in the
Console, which could be confusing since it was only SQL CPU Time.

This commit updates the title and tooltips to clarify that.

Fixes cockroachdb#116409

Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the
Console and add clarification to its tooltip.
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 14, 2023
@maryliag
ui: update label "CPU" to "SQL CPU"
3abb0a4 
Previosuly, we were using the label "CPU Time" in the
Console, which could be confusing since it was only SQL CPU Time.

This commit updates the title and tooltips to clarify that.

Fixes cockroachdb#116409

Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the
Console and add clarification to its tooltip.
@maryliag maryliag mentioned this issue Dec 14, 2023
Merged
maryliag added a commit that referenced this issue Dec 14, 2023
@maryliag
ui: update label "CPU" to "SQL CPU"
7d2d237 
Previosuly, we were using the label "CPU Time" in the
Console, which could be confusing since it was only SQL CPU Time.

This commit updates the title and tooltips to clarify that.

Fixes #116409

Release note (ui change): Update "CPU Time" label to "SQL CPU Time" on the
Console and add clarification to its tooltip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: update label "CPU" to "SQL CPU" maryliag/cockroach
1 participant
@maryliag