Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hlc: remove the Synthetic field from Timestamp and LegacyTimestamp #116830

Merged
merged 6 commits into from
Jan 10, 2024
Merged

hlc: remove the Synthetic field from Timestamp and LegacyTimestamp #116830

merged 6 commits into from
Jan 10, 2024

Commits on Jan 9, 2024

  1. kv/ptstorage: remove handling of synthetic timestamps 

    Informs cockroachdb#101938.

This commit is essentially a revert of 951add4. It removes the handling
of synthetic timestamps from the ptstorage package.

This flag has been deprecated since v22.2 and is no longer consulted in
uncertainty interval checks or by transaction commit-wait. It will never
makes its way into the ptstorage package once it is removed from the proto
definition.

Release note: None
    @nvanbenschoten
    nvanbenschoten committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9e1d700 View commit details
    Browse the repository at this point in the history

  2. changefeedccl: remove handling of synthetic timestamps 

    Informs cockroachdb#101938.

This commit is essentially a revert of 5259c1d. It removes the handling
of synthetic timestamps from the changefeedccl package.

This flag has been deprecated since v22.2 and is no longer consulted in
uncertainty interval checks or by transaction commit-wait. It will never
makes its way into the changefeedccl package once it is removed from the
proto definition.

Release note: None
    @nvanbenschoten
    nvanbenschoten committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    1b4f26e View commit details
    Browse the repository at this point in the history

  3. hlc: remove Timestamp.WithSynthetic method 

    Informs cockroachdb#101938.

This is now unused.

Release note: None
    @nvanbenschoten
    nvanbenschoten committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4288a77 View commit details
    Browse the repository at this point in the history

  4. sql: don't support AOST queries with synthetic timestamps 

    Informs cockroachdb#101938.

This commit is essentially a revert of 34dc5ae. It removes the ability
to pass a synthetic timestamp to an AOST query.

Release note (backward-incompatible change): AS OF SYSTEM TIME queries
can no longer use a timestamp followed by a question mark to signifiy a
future-time value. This was an undocumented syntax.
    @nvanbenschoten
    nvanbenschoten committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    48d702d View commit details
    Browse the repository at this point in the history

  5. hlc: remove the Synthetic field from Timestamp and LegacyTimestamp 

    Closes cockroachdb#101938.

This commit completes the work to remove the Synthetic field from
Timestamp and LegacyTimestamp. It removes the fields from the proto
definitions and removes all access to the fields in methods.

The commit also cleans up the remaining references in the code which
were just waiting for the field to be removed.

Release note: None
    @nvanbenschoten
    nvanbenschoten committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    62ebe56 View commit details
    Browse the repository at this point in the history

  6. *: remove remaining stale references to synthetic timestamps 

    Informs cockroachdb#101938.

Release note: None
    @nvanbenschoten
    nvanbenschoten committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    6f48942 View commit details
    Browse the repository at this point in the history