sql: remove connExecutor.eventLog and sql.trace.session_eventlog.enabled #117928
Conversation
petermattis
requested review from
rharding6373
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)
|
@mgartner or someone else from @cockroachdb/sql-queries, can you also give this a stamp of approval? |
|
I'm a member of SQL Queries, does my approval not count? :) Perhaps we should get a sign off from @rafiss or someone in @cockroachdb/sql-foundations. |
The `connExecutor.eventLog` was capturing session events when `sql.trace.session_eventlog.enabled` was enabled (default false). This was historically used by SQL engineers for debugging the pgwire connection state machine, but is not in current use. Epic: none Release note (sql change): Remove sql.trace.session_eventlog.enabled and the associated event log tracing. The information in these traces is still available in the DEV log channel by enabling --vmodule=conn_executor=2.
petermattis
force-pushed
the
pmattis/conn-executor-eventlog
branch
from
e5c95e1
to
60c5f07
Compare
There was a problem hiding this comment.
thank you!
Reviewed 3 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
The
connExecutor.eventLogwas capturing session events whensql.trace.session_eventlog.enabledwas enabled (default false). This was historically used by SQL engineers for debugging the pgwire connection state machine, but is not in current use.Epic: none
Release note (sql change): Remove sql.trace.session_eventlog.enabled and the associated event log tracing. The information in these traces is still available in the DEV log channel by enabling --vmodule=conn_executor=2.