-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gossip: remove gossip eventlog #117936
gossip: remove gossip eventlog #117936
Conversation
This is true after #117928 merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker, @jbowens, @nvanbenschoten, @petermattis, and @xinhaoz)
pkg/util/log/trace.go
line 43 at r1 (raw file):
// remain in the result. func eventInternal(sp *tracing.Span, isErr bool, entry *logEntry) { if sp != nil {
I don't think we need this check anymore.
pkg/util/log/trace.go
line 186 at r1 (raw file):
var _ = VErrEventfDepth // silence unused warning // HasSpan returns true if the context has a span or event that should
remote "or event"
7bd83b0
to
f17a96e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR!
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @erikgrinaker, @jbowens, @nvanbenschoten, @RaduBerinde, and @xinhaoz)
pkg/util/log/trace.go
line 43 at r1 (raw file):
Previously, RaduBerinde wrote…
I don't think we need this check anymore.
Good point. Removed.
pkg/util/log/trace.go
line 186 at r1 (raw file):
Previously, RaduBerinde wrote…
remote "or event"
Ack. I caught a number of other instances of "event log" that have been removed as well.
Remove the gossip eventlog which was the last remaining use of `AmbientContext.{Set,Finish}EventLog` allowing those methods to be removed as well. Remove `log.With{,No}EventLog` which were not being used and remove the associated eventlog machinery from `util/log`. Epic: none Release note (general change): Remove the /debug/events endpoint which is no longer populated.
f17a96e
to
e45203c
Compare
bors r+ |
This PR was included in a batch that timed out, it will be automatically retried |
This PR was included in a batch that timed out, it will be automatically retried |
Build succeeded: |
Remove the gossip eventlog which was the last remaining use of
AmbientContext.{Set,Finish}EventLog
allowing those methods to be removed as well. Removelog.With{,No}EventLog
which were not being used and remove the associated eventlog machinery fromutil/log
.Epic: none
Release note (general change): Remove the /debug/events endpoint which is no longer populated.