pkg/ui: add request status code to error messaging

[abarganier]

Fixes: #114582

We recently made some nice improvements to our error messaging in DB Console via the changes in #105550

However, these changes didn't include the HTTP response status code in the error message, which has created some guess work when interpreting error messages, especially when involving things like timeouts from the load balancer servicing the request.

This patch updates the error messaging to include the HTTP response code if the request being rendered is a RequestError. If it's not, the field is omitted.

Release note (ui change): The error messages surfaced in DB Console now include information about the HTTP response status code, if one is present.

Epic: CRDB-20791

[cockroach-teamcity]

This change is 

[koorosh]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @abarganier and @maryliag)

---

pkg/ui/workspaces/cluster-ui/src/sqlActivity/errorComponent.tsx line 21 at r1 (raw file):

interface SQLActivityErrorProps {
  statsType: string;
  error: Error;

I suggest to extend error type to Error | RequestError as it is also a possible type.

---

pkg/ui/workspaces/cluster-ui/src/sqlActivity/errorComponent.tsx line 88 at r1 (raw file):

      : "";

  const respCode = (props?.error as RequestError)?.status;

nit. util package contains isRequestError function to check whether it is plain error or RequestError. It might be more verbose but avoids explicit casting of a type.

[abarganier]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @koorosh and @maryliag)

---

pkg/ui/workspaces/cluster-ui/src/sqlActivity/errorComponent.tsx line 21 at r1 (raw file):

Previously, koorosh (Andrii Vorobiov) wrote…

I suggest to extend error type to Error | RequestError as it is also a possible type.

Good thinking! Done.

---

pkg/ui/workspaces/cluster-ui/src/sqlActivity/errorComponent.tsx line 88 at r1 (raw file):

Previously, koorosh (Andrii Vorobiov) wrote…

nit. util package contains isRequestError function to check whether it is plain error or RequestError. It might be more verbose but avoids explicit casting of a type.

Thanks for the callout - switched to using isRequestError.

Let me know if there's a more idiomatic TypeScript way to do what I'm doing here 🙂

[koorosh]

🔥

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

[abarganier]

TFTR!

bors r=koorosh

[craig]

This PR was included in a batch that timed out, it will be automatically retried

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)