Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ui: add request status code to error messaging #118782

Merged
merged 1 commit into from
Feb 6, 2024

Commits on Feb 5, 2024

  1. pkg/ui: add request status code to error messaging

    Fixes: cockroachdb#114582
    
    We recently made some nice improvements to our error messaging in DB
    Console via the changes in cockroachdb#105550
    
    However, these changes didn't include the HTTP response status code in
    the error message, which has created some guess work when interpreting
    error messages, especially when involving things like timeouts from the
    load balancer servicing the request.
    
    This patch updates the error messaging to include the HTTP response
    code if the request being rendered is a RequestError. If it's not, the
    field is omitted.
    
    Release note (ui change): The error messages surfaced in DB Console now include
    information about the HTTP response status code, if one is present.
    abarganier committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a02f06e View commit details
    Browse the repository at this point in the history