ui: take non-negative derivative of full scan chart #118787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full scan metric was previously being displayed as a count using a downsampling max aggregation function. This commit changes the full scans graph in the sql dashboard to show the non-negative derivative of the metric since this chart is more useful when displayed as a rate. Epic: none Fixes: cockroachdb#118535 Release note (ui change): The `Full Table/Index Scans` chart in the sql metrics dashboard now shows the non-negative derivative of the number of full scans tracked.
|
This change is |
xinhaoz
requested review from
a team and
abarganier
and removed request for
a team
dhartunian
approved these changes
Feb 5, 2024
|
tftr! |
xinhaoz
added
backport-23.1.x
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from d95fb57 to blathers/backport-release-23.1-118787: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full scan metric was previously being displayed as a count using a downsampling max aggregation function. This commit changes the full scans graph in the sql dashboard to show the non-negative derivative of the metric since this chart is more useful when displayed as a rate.
Epic: none
Fixes: #118535
Release note (ui change): The
Full Table/Index Scanschart in the sql metrics dashboard now shows the non-negative derivative of the number of full scans tracked.Before
After
