Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: ui: take non-negative derivative of full scan chart #118860

Merged
merged 1 commit into from Feb 16, 2024
Merged

release-23.2: ui: take non-negative derivative of full scan chart #118860

merged 1 commit into from Feb 16, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 6, 2024 •
edited by xinhaoz

Backport 1/1 commits from #118787 on behalf of @xinhaoz.

/cc @cockroachdb/release

The full scan metric was previously being displayed as a count using a downsampling max aggregation function. This commit changes the full scans graph in the sql dashboard to show the non-negative derivative of the metric since this chart is more useful when displayed as a rate.

Epic: none
Fixes: #118535

Release note (ui change): The Full Table/Index Scans chart in the sql metrics dashboard now shows the non-negative derivative of the number of full scans tracked.

Before
image

After
image

Release justification: bug fix

@xinhaoz
ui: take non-negative derivative of full scan chart
2a4b64c 
The full scan metric was previously being displayed as a count using a
downsampling max aggregation function. This commit changes the full
scans graph in the sql dashboard to show the non-negative derivative
of the metric since this chart is more useful when displayed as a rate.

Epic: none
Fixes: #118535

Release note (ui change): The `Full Table/Index Scans` chart in the sql
metrics dashboard now shows the non-negative derivative of the number of
full scans tracked.
@blathers-crl blathers-crl bot requested a review from a team as a code owner February 6, 2024 21:38
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-118787 branch from 5264ee5 to 2a4b64c Compare February 6, 2024 21:38
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 6, 2024
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Feb 6, 2024 •
edited by xinhaoz

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 6, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

abarganier
abarganier approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dhartunian)

@xinhaoz xinhaoz merged commit 50e23f4 into release-23.2 Feb 16, 2024
5 of 6 checks passed
@xinhaoz xinhaoz deleted the blathers/backport-release-23.2-118787 branch February 16, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhartunian dhartunian dhartunian approved these changes

@abarganier abarganier abarganier approved these changes

@renatolabs renatolabs renatolabs approved these changes

Assignees

@xinhaoz xinhaoz

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cockroach-teamcity @dhartunian @abarganier @renatolabs @xinhaoz