sql: fix bug with type name conflict, allow resolving any object

[rafiss]

Prior to this change there was a bug when a type name conflicted with a sequence name (#72820). This resolves that problem by adding logic to resolve any sort of object with a given name.

It also removes a bad method from sql/resolver.go

replaces #72824
fixes #72820
fixes #118753
fixes #116795

Release note (bug fix): Fixed a bug which caused an inscrutable error when a sequence name allocated by SERIAL conflicted with an existing type name.

[cockroach-teamcity]

This change is 

[blathers-crl]

It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[fqazi]

Reviewed 14 of 14 files at r1, 1 of 1 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @herkolategan, @rafiss, and @srosenberg)

---

pkg/sql/serial.go line 96 at r4 (raw file):

		RequireMutable:    false,
		IncludeOffline:    true,
		DesiredObjectKind: tree.AnyObject,

We need a similar change to the declarative CREATE SEQUENCE. It attempts to only resolve a table when it needs to check for any conflict.

i.e.:
create type t_t_seq AS enum ('a');
create sequence t_t_seq;

[rafiss]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @fqazi, @herkolategan, and @srosenberg)

---

pkg/sql/serial.go line 96 at r4 (raw file):

Previously, fqazi (Faizan Qazi) wrote…

We need a similar change to the declarative CREATE SEQUENCE. It attempts to only resolve a table when it needs to check for any conflict.

i.e.:
create type t_t_seq AS enum ('a');
create sequence t_t_seq;

nice catch. fixed

[fqazi]

Great work, and thanks for doing this

Reviewed 2 of 3 files at r3, 2 of 2 files at r5, 1 of 1 files at r6, 5 of 5 files at r7, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @srosenberg)

[rafiss]

tftr!

bors r+

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from bac933e to blathers/backport-release-23.1-118861: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

error creating merge commit from 60171b4 to blathers/backport-release-23.2-118861: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}