catalog: fix tracking of id and name state

[rafiss]

This allows us to re-enable the COMMENT ON statements in the
schemachange workload.

The previous code only updated the entries that were already in the
byIDState map. However, some descriptor IDs may not be in that map, so
instead we should add everything we just read into the map.

fixes #116795
Release note (bug fix): Fixed a bug where COMMENT statements could
fail with an "unexpected value" error if multiple COMMENT statements
were running concurrently.

[cockroach-teamcity]

This change is 

[fqazi]

Amazing find and this must have led to poor cache utilization in some cases too

Reviewed 4 of 4 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @rafiss, and @renatolabs)

---

pkg/sql/catalog/internal/catkv/catalog_reader_cached.go line 203 at r1 (raw file):

	c.hasScanNamespaceForDatabases = true
	c.hasScanAllComments = true
	if err := read.ForEachDescriptor(func(desc catalog.Descriptor) error {

Can we add a data driven test inside pkg/sql/catalog/internal/catkv/catalog_reader_test.go? I think we should also see fewer scans in some cases.

[rafiss]

tftr!

bors r+

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @fqazi, @herkolategan, and @renatolabs)

---

pkg/sql/catalog/internal/catkv/catalog_reader_cached.go line 203 at r1 (raw file):

Previously, fqazi (Faizan Qazi) wrote…

Can we add a data driven test inside pkg/sql/catalog/internal/catkv/catalog_reader_test.go? I think we should also see fewer scans in some cases.

done

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 978a826 to blathers/backport-release-23.2-119007: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}