Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: --include-range-info flag for cockroach debug zip also toggles problem ranges #119205

Merged
merged 1 commit into from Feb 14, 2024

Conversation

nkodali
Copy link
Collaborator

@nkodali nkodali commented Feb 14, 2024

Previously, the --include-range-info flag only toggled inclusion of one file per node with information on KV ranges on that node. This change also toggles inclusion of problem ranges with the same flag, as there is suspected cluster performance degradation for large clusters when fetching problem ranges.

Fixes: #118991

Release note (ops change): Expanded --include-range-info flag to additionally include problem ranges. This is still defaulted to true.

… problem ranges

Previously, the --include-range-info flag only toggled inclusion of
one file per node with information on KV ranges on that node.
This change also toggles inclusion of problem ranges with the same
flag, as there is suspected cluster performance degradation for
large clusters when fetching problem ranges.

Fixes: cockroachdb#118991

Release note (ops change): Expanded --include-range-info flag to
additionally include problem ranges. This is still defaulted to true.
@nkodali nkodali requested review from a team as code owners February 14, 2024 15:20
@nkodali nkodali requested review from abarganier and removed request for a team February 14, 2024 15:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nkodali nkodali added backport-22.2.x Flags PRs that need to be backported to 22.2. backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Feb 14, 2024
Copy link
Member

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@nkodali
Copy link
Collaborator Author

nkodali commented Feb 14, 2024

bors r=abarganier

@craig
Copy link
Contributor

craig bot commented Feb 14, 2024

Build succeeded:

@craig craig bot merged commit cc6ca02 into cockroachdb:master Feb 14, 2024
12 checks passed
Copy link

blathers-crl bot commented Feb 14, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4b24149 to blathers/backport-release-22.2-119205: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error creating merge commit from 4b24149 to blathers/backport-release-23.1-119205: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from 4b24149 to blathers/backport-release-23.2-119205: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: expand --include-range-info flag for cockroach debug zip to additionally exclude problem ranges
3 participants