Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: cli: --include-range-info flag for cockroach debug zip also toggles problem ranges #119233

Merged
merged 1 commit into from Feb 20, 2024

Conversation

nkodali
Copy link
Collaborator

@nkodali nkodali commented Feb 15, 2024

Backport 1/1 commits from #119205.

/cc @cockroachdb/release


Previously, the --include-range-info flag only toggled inclusion of one file per node with information on KV ranges on that node. This change also toggles inclusion of problem ranges with the same flag, as there is suspected cluster performance degradation for large clusters when fetching problem ranges.

Fixes: #118991

Release note (ops change): Expanded --include-range-info flag to additionally include problem ranges. This is still defaulted to true.

Release justification: low risk cli change to debug zip flag

@nkodali nkodali requested review from a team as code owners February 15, 2024 05:49
@nkodali nkodali requested review from abarganier and removed request for a team February 15, 2024 05:49
Copy link

blathers-crl bot commented Feb 15, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 15, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

… problem ranges

Previously, the --include-range-info flag only toggled inclusion of
one file per node with information on KV ranges on that node.
This change also toggles inclusion of problem ranges with the same
flag, as there is suspected cluster performance degradation for
large clusters when fetching problem ranges.

Fixes: cockroachdb#118991

Release note (ops change): Expanded --include-range-info flag to
additionally include problem ranges. This is still defaulted to true.

Release justification: low risk cli change to debug zip flag
@nkodali nkodali merged commit 7159394 into cockroachdb:release-23.1 Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants