roachtest: assert limit capacity throughput 90% of baseline #119652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
requested review from
srosenberg and
renatolabs
and removed request for
a team
kvoli
force-pushed
the
240226.roachtest-limit-capacity-assertions
branch
from
f81c1cb
to
3c95a3d
Compare
|
Requires #119776 to pass. |
7 tasks
andrewbaptist
approved these changes
Mar 28, 2024
The 2 minutes felt too generous. I'm re-running some tests now to confirm the minute is reasonable. |
|
Current results off master:
|
|
Vs without shedding
|
This commit enables a throughput assertion on the `limit_capacity` roachtests. The assertion requires that throughput after limiting some nodes capacity is at least 90% of the pre-limit throughput after 2 minutes. Part of: cockroachdb#118866 Release note: None
kvoli
force-pushed
the
240226.roachtest-limit-capacity-assertions
branch
from
3c95a3d
to
d8f2742
Compare
|
Failed 1/10 runs for the The failure was simply due to slower L0 sublevel growth than the other runs. I'll leave the period at 2 minutes. |
|
TYFTR bors r=andrewbaptist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables a throughput assertion on the
limit_capacityroachtests. The assertion requires that throughput after limiting some
nodes capacity is at least 90% of the pre-limit throughput after 2
minutes.
Part of: #118866
Release note: None