Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: roachtest: assert limit capacity throughput 90% of baseline #121308

Open
wants to merge 1 commit into
base: release-24.1
Choose a base branch
from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 28, 2024

Backport 1/1 commits from #119652 on behalf of @kvoli.

/cc @cockroachdb/release


This commit enables a throughput assertion on the limit_capacity
roachtests. The assertion requires that throughput after limiting some
nodes capacity is at least 90% of the pre-limit throughput after 2
minutes.

Part of: #118866
Release note: None


Release justification: Test only.

This commit enables a throughput assertion on the `limit_capacity`
roachtests. The assertion requires that throughput after limiting some
nodes capacity is at least 90% of the pre-limit throughput after 2
minutes.

Part of: #118866
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 28, 2024 22:05
@blathers-crl blathers-crl bot requested review from DarrylWong and removed request for a team March 28, 2024 22:05
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-119652 branch from 9b344b1 to d2e8cf7 Compare March 28, 2024 22:05
@blathers-crl blathers-crl bot requested a review from renatolabs March 28, 2024 22:05
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 28, 2024
Copy link
Author

blathers-crl bot commented Mar 28, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from srosenberg March 28, 2024 22:05
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 28, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist
Copy link
Collaborator

I'm not sure we should backport this yet. Can we wait until it has been running at least 2 weeks on master without failure before we backport. If it doesn't fail then it is safe to backport, but while this change is good, it has the risk of adding a flake to an otherwise non-flaky test.

Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Copy link

github-actions bot commented May 6, 2024

Reminder: it has been 3 weeks please merge or close your backport!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants