ui: disallow VIEW type tables from being shown in the db pages #119890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we filtered out `SYSTEM VIEW` tables from being shown in the db pages but not user created views. We now filter out all VIEW type tables from the db pages. Epic: none Fixes: cockroachdb#119789 Release note (bug fix): Users will no longer see VIEW type tables from being shown in the db-console databases pages. Previously these would be listed with no info, only displaying errors.
|
This change is |
xinhaoz
requested review from
a team and
dhartunian
and removed request for
a team
xinhaoz
added
backport-23.1.x
dhartunian
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
|
TFTR! |
|
Build succeeded: |
This was referenced Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we filtered out
SYSTEM VIEWtables from being shown in the db pages but not user created views. We now filter out all VIEW type tables from the db pages.Epic: none
Fixes: #119789
Release note (bug fix): Users will no longer see VIEW type tables from being shown in the db-console databases pages. Previously these would be listed with no info, only displaying errors.
Before:
boo is a view on foo
After:
