New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: ui: disallow VIEW type tables from being shown in the db pages #120213
Conversation
Previously we filtered out `SYSTEM VIEW` tables from being shown in the db pages but not user created views. We now filter out all VIEW type tables from the db pages. Epic: none Fixes: #119789 Release note (bug fix): Users will no longer see VIEW type tables from being shown in the db-console databases pages. Previously these would be listed with no info, only displaying errors.
215ac50
to
1be23e8
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
Backport 1/1 commits from #119890 on behalf of @xinhaoz.
/cc @cockroachdb/release
Previously we filtered out
SYSTEM VIEW
tables from being shown in the db pages but not user created views. We now filter out all VIEW type tables from the db pages.Epic: none
Fixes: #119789
Release note (bug fix): Users will no longer see VIEW type tables from being shown in the db-console databases pages. Previously these would be listed with no info, only displaying errors.
Before:
boo is a view on foo
After:
Release justification: bug fix