Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: disallow VIEW type tables from being shown in the db pages #120213

Merged
merged 1 commit into from Mar 20, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 11, 2024

Backport 1/1 commits from #119890 on behalf of @xinhaoz.

/cc @cockroachdb/release


Previously we filtered out SYSTEM VIEW tables from being shown in the db pages but not user created views. We now filter out all VIEW type tables from the db pages.

Epic: none
Fixes: #119789

Release note (bug fix): Users will no longer see VIEW type tables from being shown in the db-console databases pages. Previously these would be listed with no info, only displaying errors.

Before:
boo is a view on foo
Pasted Graphic
Cluster id aa0f4c7e-Sdbb-473f-a92f-5da7d017ecSc

After:
Pasted Graphic 2


Release justification: bug fix

Previously we filtered out `SYSTEM VIEW` tables from being shown
in the db pages but not user created views. We now filter out
all VIEW type tables from the db pages.

Epic: none
Fixes: #119789

Release note (bug fix): Users will no longer see VIEW type tables
from being shown in the db-console databases pages. Previously
these would be listed with no info, only displaying errors.
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 11, 2024 15:39
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-119890 branch from 215ac50 to 1be23e8 Compare March 11, 2024 15:39
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 11, 2024
Copy link
Author

blathers-crl bot commented Mar 11, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from dhartunian March 11, 2024 15:39
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 11, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian dhartunian requested a review from xinhaoz March 18, 2024 14:00
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)

@xinhaoz xinhaoz requested a review from rafiss March 18, 2024 15:22
@xinhaoz xinhaoz merged commit d3221f7 into release-23.1 Mar 20, 2024
6 checks passed
@xinhaoz xinhaoz deleted the blathers/backport-release-23.1-119890 branch March 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants