cluster-ui: fix insights page crash #120137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
reviewed
Mar 8, 2024
| @@ -564,7 +564,7 @@ export class Filter extends React.Component<QueryFilter, FilterState> { | |||
| })) | |||
| : []; | |||
| const schemaInsightTypeValue = schemaInsightTypeOptions.filter(option => { | |||
| return filters.schemaInsightType.split(",").includes(option.label); | |||
| return filters.schemaInsightType?.split(",").includes(option.label); | |||
There was a problem hiding this comment.
If we're changing this code anyways, can we create the array (or set) outside of the filter fn:
const selectedSchemaInsightTypes = filters.schemaInsightType?.split(",") ?? [];
const schemaInsightTypeValue = schemaInsightTypeOptions.filter(option => selectedSchemaInsightTypes.includes(option.label);
);
There was a problem hiding this comment.
Done! I went ahead and fixed all the other issues of the same type in the file since we see these errors in the console logs quite frequently.
laurenbarker
force-pushed
the
insights-page-error
branch
from
4838010
to
4727609
Compare
When the Schema Insights Type is unitialized, the Schema Insights tab would crash because a string method was being called on `undefined`. The types are all correct, but because strict mode isn't enabled, it's not considered a type error. Now the string method is only called if the Schema Insights Type is defined. The same type issue that was fixed for `filters.schemaInsightType` was fixed for all other filters in the same file as well. Fixes: https://cockroachlabs.atlassian.net/browse/CC-27391 Release note (bug fix): Fixes intermittent page crash on the Schema Insights view.
laurenbarker
force-pushed
the
insights-page-error
branch
from
4727609
to
a22845e
Compare
xinhaoz
approved these changes
Mar 8, 2024
|
TFTR @xinhaoz! |
|
bors r+ |
laurenbarker
added
backport-23.1.x
|
blathers backport 23.2 |
laurenbarker
removed
the
backport-23.2.x
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Schema Insights Type is unitialized, the Schema Insights tab would crash because a string method was being called on
undefined. The types are all correct, but because strict mode isn't enabled, it's not considered a type error.Now the string method is only called if the Schema Insights Type is defined.
Fixes: https://cockroachlabs.atlassian.net/browse/CC-27391
Release note (bug fix): Fixes intermittent page crash on the Schema Insights view.