Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-ui: fix insights page crash #120137

Merged
merged 1 commit into from
Mar 11, 2024

Commits on Mar 8, 2024

  1. cluster-ui: fix insights page crash

    When the Schema Insights Type is unitialized, the Schema Insights tab
    would crash because a string method was being called on `undefined`. The
    types are all correct, but because strict mode isn't enabled, it's not
    considered a type error.
    
    Now the string method is only called if the Schema Insights Type is
    defined.
    
    The same type issue that was fixed for `filters.schemaInsightType` was
    fixed for all other filters in the same file as well.
    
    Fixes: https://cockroachlabs.atlassian.net/browse/CC-27391
    
    Release note (bug fix): Fixes intermittent page crash on the Schema
    Insights view.
    laurenbarker committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a22845e View commit details
    Browse the repository at this point in the history