Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.18-rc: util/mon: lose more references on Stop #120810

Merged

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 21, 2024

Backport 1/1 commits from #120789 on behalf of @yuzefovich.

/cc @cockroachdb/release


Backport 1/1 commits from #120764.

/cc @cockroachdb/release


This commit makes it so that we also now lose the references from the monitor being Stopped to its siblings to aid GC. This was omitted by mistake originally and perhaps could make GC's job harder.

Epic: None

Release note: None

Release justification: low-risk improvement.

This commit makes it so that we also now lose the references from the
monitor being `Stop`ped to its siblings to aid GC. This was omitted by
mistake originally and _perhaps_ could make GC's job harder.

Epic: None

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.18-rc-120789 branch from 60c6aa5 to 2b20437 Compare March 21, 2024 04:25
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 21, 2024
@blathers-crl blathers-crl bot requested a review from DrewKimball March 21, 2024 04:25
Copy link
Author

blathers-crl bot commented Mar 21, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 21, 2024
Copy link
Author

blathers-crl bot commented Mar 21, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich changed the title release-23.1.18-rc: release-23.1: util/mon: lose more references on Stop release-23.1.18-rc: util/mon: lose more references on Stop Mar 21, 2024
@yuzefovich yuzefovich merged commit e49c1e5 into release-23.1.18-rc Mar 22, 2024
6 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1.18-rc-120789 branch March 22, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants