Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.1: roachtest: assert limit capacity throughput 90% of baseline #121308

Open
wants to merge 1 commit into
base: release-24.1
Choose a base branch
from
Open

release-24.1: roachtest: assert limit capacity throughput 90% of baseline #121308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 2 additions & 11 deletions pkg/cmd/roachtest/tests/limit_capacity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,6 @@ func runLimitCapacity(ctx context.Context, t test.Test, c cluster.Cluster, cfg l
for _, cancel := range cancels {
cancel()
}
// We should be able to assert on the throughput not dropping beyond a
// certain % of the throughput prior to limiting a node's capacity.
//
// TODO(kvoli): Currently this test will fail an assertion that the final QPS
// will be >50% of the pre-limit QPS. Once we begin shedding leases off the
// limited node, this assertion would pass. Add in these assertions once
// shedding is done, or alternatively enable the test weekly and export the
// relative QPS to roachperf. Two potential assertions are:
//
// (a) expect throughput to not drop by more than X%
// (b) measure the throughput at set marks (10s, 30s, 1m, 5m) and assert.
// Expect that the relative QPS is at least 90% of the starting QPS.
require.GreaterOrEqual(t, qpsRelative, 0.9)
}