Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: changefeedccl: fix memory leak in deprecatedGcpPubsubClient #121867

Merged
merged 1 commit into from Apr 11, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 5, 2024

Backport 1/1 commits from #121817 on behalf of @wenyihu6.

/cc @cockroachdb/release


Previously, deprecatedGcpPubsubClient did not close pubsub.Client properly
which could lead to memory leaks. This patch fixes the problem by invoking
pubsub.Client.Close() during deprecatedGcpPubsubClient.Close().

Epic: none
Release note: Fixed a slow memory leak in deprecated pubsub changefeeds which
can accumulate when restarting/cancelling many deprecated pubsub changefeeds.
The bug had been there since the deprecated pubsub was introduced in 22.1
(beta).


Release justification: (low-risk change) Fixed a bug which could lead to slow memory leak.

@blathers-crl blathers-crl bot requested a review from a team as a code owner April 5, 2024 21:16
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-121817 branch from dea4c7f to aca5a10 Compare April 5, 2024 21:16
@blathers-crl blathers-crl bot requested review from andyyang890 and removed request for a team April 5, 2024 21:16
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 5, 2024
@blathers-crl blathers-crl bot requested a review from rharding6373 April 5, 2024 21:16
Copy link
Author

blathers-crl bot commented Apr 5, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from wenyihu6 April 5, 2024 21:16
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 5, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, `deprecatedGcpPubsubClient` did not close `pubsub.Client` properly
which could lead to memory leaks. This patch fixes the problem by invoking
`pubsub.Client.Close()` during `deprecatedGcpPubsubClient.Close()`.

Epic: none
Release note: Fixed a slow memory leak in deprecated pubsub changefeeds which
can accumulate when restarting/cancelling many deprecated pubsub changefeeds.
The bug had been there since the deprecated pubsub was introduced in 22.1
(beta).
@wenyihu6 wenyihu6 force-pushed the blathers/backport-release-24.1-121817 branch from aca5a10 to d71a928 Compare April 11, 2024 14:29
@wenyihu6
Copy link
Contributor

The last push was to trigger local_roachtest which was stuck in CI.

@wenyihu6 wenyihu6 merged commit 8a6a600 into release-24.1 Apr 11, 2024
20 checks passed
@wenyihu6 wenyihu6 deleted the blathers/backport-release-24.1-121817 branch April 11, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants