New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: changefeedccl: fix memory leak in deprecatedGcpPubsubClient #121867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.1-121817
branch
from
April 5, 2024 21:16
dea4c7f
to
aca5a10
Compare
blathers-crl
bot
requested review from
andyyang890
and removed request for
a team
April 5, 2024 21:16
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 5, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Apr 5, 2024
rharding6373
approved these changes
Apr 8, 2024
stevendanna
approved these changes
Apr 9, 2024
Previously, `deprecatedGcpPubsubClient` did not close `pubsub.Client` properly which could lead to memory leaks. This patch fixes the problem by invoking `pubsub.Client.Close()` during `deprecatedGcpPubsubClient.Close()`. Epic: none Release note: Fixed a slow memory leak in deprecated pubsub changefeeds which can accumulate when restarting/cancelling many deprecated pubsub changefeeds. The bug had been there since the deprecated pubsub was introduced in 22.1 (beta).
wenyihu6
force-pushed
the
blathers/backport-release-24.1-121817
branch
from
April 11, 2024 14:29
aca5a10
to
d71a928
Compare
The last push was to trigger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #121817 on behalf of @wenyihu6.
/cc @cockroachdb/release
Previously,
deprecatedGcpPubsubClient
did not closepubsub.Client
properlywhich could lead to memory leaks. This patch fixes the problem by invoking
pubsub.Client.Close()
duringdeprecatedGcpPubsubClient.Close()
.Epic: none
Release note: Fixed a slow memory leak in deprecated pubsub changefeeds which
can accumulate when restarting/cancelling many deprecated pubsub changefeeds.
The bug had been there since the deprecated pubsub was introduced in 22.1
(beta).
Release justification: (low-risk change) Fixed a bug which could lead to slow memory leak.