merge staging-v23.1.19 to release-23.1: released CockroachDB version 23.1.19. Next version: 23.1.20 #122635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the cluster setting sql.auth.modify_cluster_setting_applies_to_all.enabled which determines whether users with MODIFYCLUSTERSETTING are able to edit non sql.defaults settings. It also allows this setting to prevent viewing sql.default settings. Additionally, a deprecation warning is added for this cluster setting to inform that it should be replaced once the cluster is finalized Fixes: cockroachdb#122023 Release note (bug fix): reintroduce sql.auth.modify_cluster_setting_applies_to_all.enabled so that mixed version clusters can migrate off this setting.
…1.19 Release note: None Epic: None Release justification: non-production (release infra) change.
…ort-staging-v23.1.19-122055 staging-v23.1.19: release-23.1: sql: regulate MODIFYCLUSTERSETTING with cluster setting
…ort-staging-v23.1.19-122234 staging-v23.1.19: release-23.1: released CockroachDB version 23.1.18. Next version: 23.1.19
…23.1.19. Next version: 23.1.20 Release note: None Epic: None Release justification: non-production (release infra) change.
|
This change is |
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @cockroach-teamcity)
rsevinsky-cr
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None
Epic: None
Release justification: non-production (release infra) change.