-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: bump Pebble to 0be5a7466e36 #123247
Merged
craig
merged 1 commit into
cockroachdb:master
from
RaduBerinde:radu/pebble-master-0be5a7466e36
Apr 30, 2024
Merged
go.mod: bump Pebble to 0be5a7466e36 #123247
craig
merged 1 commit into
cockroachdb:master
from
RaduBerinde:radu/pebble-master-0be5a7466e36
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbowens
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bors r+ |
Build failed: |
Changes: * [`0be5a746`](cockroachdb/pebble@0be5a746) db: add variants of memtable iterator benchmarks with bounds * [`85321d0b`](cockroachdb/pebble@85321d0b) internal/batchskl: remove iterAdapter * [`e7c4ec2e`](cockroachdb/pebble@e7c4ec2e) manifest: show iterator command in output * [`3a02db68`](cockroachdb/pebble@3a02db68) manifest: fix some tests that have split keys * [`446a0811`](cockroachdb/pebble@446a0811) db: move obsolete files code * [`f1311686`](cockroachdb/pebble@f1311686) db: rename cleanup.go to obsolete_files.go * [`57ee5be2`](cockroachdb/pebble@57ee5be2) sstable: remove ExternalFormatVersion * [`5b3f94f1`](cockroachdb/pebble@5b3f94f1) db: minor cleanup of compaction code * [`a1e8dbd9`](cockroachdb/pebble@a1e8dbd9) compact: move iterator arguments into a struct * [`36521833`](cockroachdb/pebble@36521833) internal/keyspan: fix interleaving iter intermediary state * [`e751b780`](cockroachdb/pebble@e751b780) internal/keyspan: refactor interleaving iterator tests * [`17a96020`](cockroachdb/pebble@17a96020) db: extract level checker's handling of point keys * [`3cd41226`](cockroachdb/pebble@3cd41226) db: update newIters callers to use new interface * [`cd567320`](cockroachdb/pebble@cd567320) compact: move out compaction iterator * [`78b10dfd`](cockroachdb/pebble@78b10dfd) compact: add Snapshots type * [`b62bb7f0`](cockroachdb/pebble@b62bb7f0) base: move some test utils to base * [`e0c6d173`](cockroachdb/pebble@e0c6d173) keyspan: remove no longer used Fragmenter code * [`a1a8d68e`](cockroachdb/pebble@a1a8d68e) db: remove fragmenters from compactionIter Release note: none. Epic: none.
RaduBerinde
force-pushed
the
radu/pebble-master-0be5a7466e36
branch
from
April 30, 2024 03:20
a56101b
to
d72f3f6
Compare
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
0be5a746
db: add variants of memtable iterator benchmarks with bounds85321d0b
internal/batchskl: remove iterAdaptere7c4ec2e
manifest: show iterator command in output3a02db68
manifest: fix some tests that have split keys446a0811
db: move obsolete files codef1311686
db: rename cleanup.go to obsolete_files.go57ee5be2
sstable: remove ExternalFormatVersion5b3f94f1
db: minor cleanup of compaction codea1e8dbd9
compact: move iterator arguments into a struct36521833
internal/keyspan: fix interleaving iter intermediary statee751b780
internal/keyspan: refactor interleaving iterator tests17a96020
db: extract level checker's handling of point keys3cd41226
db: update newIters callers to use new interfacecd567320
compact: move out compaction iterator78b10dfd
compact: add Snapshots typeb62bb7f0
base: move some test utils to basee0c6d173
keyspan: remove no longer used Fragmenter codea1a8d68e
db: remove fragmenters from compactionIterRelease note: none.
Epic: none.