Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump Pebble to 0be5a7466e36 #123247

Merged

Conversation

RaduBerinde
Copy link
Member

Changes:

  • 0be5a746 db: add variants of memtable iterator benchmarks with bounds
  • 85321d0b internal/batchskl: remove iterAdapter
  • e7c4ec2e manifest: show iterator command in output
  • 3a02db68 manifest: fix some tests that have split keys
  • 446a0811 db: move obsolete files code
  • f1311686 db: rename cleanup.go to obsolete_files.go
  • 57ee5be2 sstable: remove ExternalFormatVersion
  • 5b3f94f1 db: minor cleanup of compaction code
  • a1e8dbd9 compact: move iterator arguments into a struct
  • 36521833 internal/keyspan: fix interleaving iter intermediary state
  • e751b780 internal/keyspan: refactor interleaving iterator tests
  • 17a96020 db: extract level checker's handling of point keys
  • 3cd41226 db: update newIters callers to use new interface
  • cd567320 compact: move out compaction iterator
  • 78b10dfd compact: add Snapshots type
  • b62bb7f0 base: move some test utils to base
  • e0c6d173 keyspan: remove no longer used Fragmenter code
  • a1a8d68e db: remove fragmenters from compactionIter

Release note: none.
Epic: none.

@RaduBerinde RaduBerinde requested review from jbowens and a team April 29, 2024 19:43
@RaduBerinde RaduBerinde requested a review from a team as a code owner April 29, 2024 19:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 29, 2024

Build failed:

Changes:

 * [`0be5a746`](cockroachdb/pebble@0be5a746) db: add variants of memtable iterator benchmarks with bounds
 * [`85321d0b`](cockroachdb/pebble@85321d0b) internal/batchskl: remove iterAdapter
 * [`e7c4ec2e`](cockroachdb/pebble@e7c4ec2e) manifest: show iterator command in output
 * [`3a02db68`](cockroachdb/pebble@3a02db68) manifest: fix some tests that have split keys
 * [`446a0811`](cockroachdb/pebble@446a0811) db: move obsolete files code
 * [`f1311686`](cockroachdb/pebble@f1311686) db: rename cleanup.go to obsolete_files.go
 * [`57ee5be2`](cockroachdb/pebble@57ee5be2) sstable: remove ExternalFormatVersion
 * [`5b3f94f1`](cockroachdb/pebble@5b3f94f1) db: minor cleanup of compaction code
 * [`a1e8dbd9`](cockroachdb/pebble@a1e8dbd9) compact: move iterator arguments into a struct
 * [`36521833`](cockroachdb/pebble@36521833) internal/keyspan: fix interleaving iter intermediary state
 * [`e751b780`](cockroachdb/pebble@e751b780) internal/keyspan: refactor interleaving iterator tests
 * [`17a96020`](cockroachdb/pebble@17a96020) db: extract level checker's handling of point keys
 * [`3cd41226`](cockroachdb/pebble@3cd41226) db: update newIters callers to use new interface
 * [`cd567320`](cockroachdb/pebble@cd567320) compact: move out compaction iterator
 * [`78b10dfd`](cockroachdb/pebble@78b10dfd) compact: add Snapshots type
 * [`b62bb7f0`](cockroachdb/pebble@b62bb7f0) base: move some test utils to base
 * [`e0c6d173`](cockroachdb/pebble@e0c6d173) keyspan: remove no longer used Fragmenter code
 * [`a1a8d68e`](cockroachdb/pebble@a1a8d68e) db: remove fragmenters from compactionIter

Release note: none.
Epic: none.
@RaduBerinde RaduBerinde force-pushed the radu/pebble-master-0be5a7466e36 branch from a56101b to d72f3f6 Compare April 30, 2024 03:20
@RaduBerinde RaduBerinde requested a review from a team as a code owner April 30, 2024 03:20
@RaduBerinde
Copy link
Member Author

bors r+

@craig craig bot merged commit d8c699b into cockroachdb:master Apr 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants