ui: add "overview" dashboard #13348
Merged
ui: add "overview" dashboard #13348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work. This is going to have great impact! I think for now we can remove "Transactions" I would also shift capacity to the bottom and I'm also cool with taking it out from this main page |
|
Looks great! Agree with Vivek that it's going to be very helpful to have the overview as the default landing.
… On Feb 1, 2017, at 12:27, vivekmenezes ***@***.***> wrote:
Great work. This is going to have great impact!
I think for now we can remove "Transactions"
I would also shift capacity to the bottom and I'm also cool with taking it out from this main page
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Code is LGTM |
mrtracy
approved these changes
Feb 1, 2017
6 tasks
maxlang
force-pushed
the
maxlang/ui-cluster-overview-dashboard
branch
from
4c85a8d
to
2d22d84
Compare
|
@vivekmenezes made those tweaks and will merge after teamcity passes |
This adds an overview dashboard with some stats that draw from the other dashboards. It's meant to be a better landing dashboard than any of the other, more specific, dashboards. It's also now the new default dashboard. Fixes cockroachdb#13163
maxlang
force-pushed
the
maxlang/ui-cluster-overview-dashboard
branch
from
2d22d84
to
4f5ae1d
Compare
|
LGTM
…On Tue, Feb 7, 2017 at 4:35 PM Max Lang ***@***.***> wrote:
@vivekmenezes <https://github.com/vivekmenezes> made those tweaks and
will merge after teamcity passes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13348 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALOpBIuFaYzqlWVx0NqUCHd3xqmmG9Ohks5raOO2gaJpZM4L0VCb>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an overview dashboard with some stats that draw from
the other dashboards. It's meant to be a better landing dashboard
than any of the other, more specific, dashboards. It's also now
the new default dashboard.
Fixes #13163
cc @vivekmenezes @kuanluo
This change is