cli: Keep client and server flags more separate #14612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, the client port flag's environment variable could get pulled in and used by the server even though the server's port flag isn't supposed to support being set by an env variable. That's the problem with setting package globals for these. It'd be nice to only even define the flags for the command being run, but that's tricky to do with pflags since all of its "PreRun" functionality runs after flags have already been parsed.
|
LGTM |
a-robinson
added a commit
to a-robinson/cockroach
that referenced
this pull request
Apr 7, 2017
They were broken by cockroachdb#14612 in a very bad way. We were always resetting the base.Config's Addr and AdvertiseAddr in the last couple assignments of `extraFlagInit`, such that the host/advertise-host flags actually don't do anything, and such that the port flag doesn't do anything when not running in insecure mode. I've added some tests, but we'd probably be better off testing this by going through the entire `cockroach start` machinery with a few different variations. Does that fit best under the acceptance tests? Or the cli Example_xxx tests? Fixes cockroachdb#14681 (once a new "latest" docker image is cut).
a-robinson
added a commit
to a-robinson/cockroach
that referenced
this pull request
Apr 7, 2017
They were broken by cockroachdb#14612 in a very bad way. We were always resetting the base.Config's Addr and AdvertiseAddr in the last couple assignments of `extraFlagInit`, such that the host/advertise-host flags actually don't do anything, and such that the port flag doesn't do anything when not running in insecure mode. I've added some tests, but we'd probably be better off testing this by going through the entire `cockroach start` machinery with a few different variations. Does that fit best under the acceptance tests? Or the cli Example_xxx tests? Fixes cockroachdb#14681 (once a new "latest" docker image is cut).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the client port flag's environment variable could get
pulled in and used by the server even though the server's port flag
isn't supposed to support being set by an env variable.
That's the problem with setting package globals for these. It'd be nice
to only even define the flags for the command being run, but that's
tricky to do with pflags since all of its "PreRun" functionality runs
after flags have already been parsed.
Fixes #8876. cc #9189
@mberhault
This change is