Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update readline dep, use our fork #16714

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

jordanlewis
Copy link
Member

This fixes a bug with long sql histories getting rewritten incorrectly.

This fixes a bug with long sql histories getting rewritten incorrectly.
@jordanlewis jordanlewis requested review from dt and knz June 26, 2017 18:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented Jun 26, 2017

I see what you did there, but is this the right approach? Why not changing the cli dep to our fork directly?

@dt
Copy link
Member

dt commented Jun 26, 2017

@knz We don't usually rewrite the import paths to point to our fork, at least if we have any intention of tracking upstream, going back if changes merge or even just merging upstream patches, since any internal imports in the lib need to be rewritten too.


Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@dt
Copy link
Member

dt commented Jun 26, 2017

:lgtm:


Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@knz
Copy link
Contributor

knz commented Jun 26, 2017

ack, that makes sense, thanks.

@jordanlewis jordanlewis merged commit a622a84 into cockroachdb:master Jun 26, 2017
@jordanlewis jordanlewis deleted the update-readline branch June 26, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants