storageccl: turn default import batch size down to 32MB #18037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63MB seemed like a safe size for the import batch size, but resulted in errors
like
command is too large: 68166516 bytes (max: 67108864)
on some restores. Turn the size down to 32MB to avoid these errors.
|
This change is |
|
I think it's worth merging this as-is. But we may want to consider removing the maxImportBatchSize logic as a followup. Doesn't seem super useful anymore Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
Agreed, but I think it's worth understanding why it's broken first. Concerning that Raft seems to be adding 10MB of overhead to the batch request. |
|
Wanna file a 1.2 issue to follow up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
63MB seemed like a safe size for the import batch size, but resulted in errors
like
on some restores. Turn the size down to 32MB to avoid these errors.