storage: don't set {,TxnSpan}GCThreshold to zero-values #18834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This needs a test. |
|
I'm probably not going to get to a test today. I think we should merge this PR as I'm 99% sure it fixes the problem and I'll follow up with a test tomorrow or Friday. |
tbg
approved these changes
Sep 27, 2017
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Oct 2, 2017
Changing the nullability of proto fields is tricky. PRs cockroachdb#18825 introduced (at least) two (cockroachdb#18835 and \cockroachdb#18834) bugs that we found relatively quickly, but not in CI. In the spirit of advancing cockroachdb#18811, here's an attempt at making our CI provoke these types of errors more aggressively. Basically, establish a struct tag `cockroachdb:"randnullable"` that instructs `protoutil.Marshal` to randomly turn `nil` fields into pointers to the zero value. This is allocation heavy (due to the need to avoid data races), so it is disabled with the `bench` build tag. We can then annotate fields whose nullability we change and get more coverage of the implications of that change. I was able to reproduce both cockroachdb#18835 (with `TestStoreRangeLease` going into an infinite loop) and \cockroachdb#18834 (with a lot of assertion crashes). @petermattis I'm probably missing a few fields. Care to point out which ones should also be fuzzed?
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Oct 2, 2017
Changing the nullability of proto fields is tricky. PRs cockroachdb#18825 introduced (at least) two (cockroachdb#18835 and \cockroachdb#18834) bugs that we found relatively quickly, but not in CI. In the spirit of advancing cockroachdb#18811, here's an attempt at making our CI provoke these types of errors more aggressively. Basically, establish a struct tag `cockroachdb:"randnullable"` that instructs `protoutil.Marshal` to randomly turn `nil` fields into pointers to the zero value. This is allocation heavy (due to the need to avoid data races), so it is disabled outside of race builds. We can then annotate fields whose nullability we change and get more coverage of the implications of that change. I was able to reproduce both cockroachdb#18835 (with `TestStoreRangeLease` going into an infinite loop) and \cockroachdb#18834 (with a lot of assertion crashes). @petermattis I'm probably missing a few fields. Care to point out which ones should also be fuzzed?
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Oct 2, 2017
Changing the nullability of proto fields is tricky. PRs cockroachdb#18825 introduced (at least) two (cockroachdb#18835 and \cockroachdb#18834) bugs that we found relatively quickly, but not in CI. In the spirit of advancing cockroachdb#18811, here's an attempt at making our CI provoke these types of errors more aggressively. Basically, establish a struct tag `cockroachdb:"randnullable"` that instructs `protoutil.Marshal` to randomly turn `nil` fields into pointers to the zero value. This is allocation heavy (due to the need to avoid data races), so it is disabled outside of race builds. We can then annotate fields whose nullability we change and get more coverage of the implications of that change. I was able to reproduce both cockroachdb#18835 (with `TestStoreRangeLease` going into an infinite loop) and \cockroachdb#18834 (with a lot of assertion crashes). @petermattis I'm probably missing a few fields. Care to point out which ones should also be fuzzed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18831