cherrypick-1.1: sqlccl: cleanup failed or canceled RESTORE data #19653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, if a RESTORE failed or was manually canceled, any data it had committed would have been orphaned, and forever taken up space. Since there was no table descriptor, nothing would have been able to see or delete it. Add optional callbacks in jobs code to allow for specific jobs to implement an onFail method. Add the job's client.Txn to the update method and this onFail callback to allow for a job to be transactionally failed and cleaned up. Release note: Cleanup partially restored data when a RESTORE fails or is canceled. This PR is from #19578 but with all of the settings passing removed, since 1.1 doesn't have any cluster settings for backup/restore. Fixes #19398 Fixes #17123
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a RESTORE failed or was manually canceled, any data
it had committed would have been orphaned, and forever taken up
space. Since there was no table descriptor, nothing would have been
able to see or delete it.
Add optional callbacks in jobs code to allow for specific jobs
to implement an onFail method. Add the job's client.Txn to the
update method and this onFail callback to allow for a job to be
transactionally failed and cleaned up.
Release note: Cleanup partially restored data when a RESTORE fails
or is canceled.
This PR is from #19578 but with all of the settings passing removed,
since 1.1 doesn't have any cluster settings for backup/restore.
Fixes #19398
Fixes #17123