Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: move benchmark tests to a new bench package #20106

Merged
merged 1 commit into from Nov 20, 2017

Conversation

knz
Copy link
Contributor

@knz knz commented Nov 16, 2017

As suggested by @jordanlewis here and here.

@knz knz requested review from jordanlewis and a team November 16, 2017 19:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member

:lgtm:

Please post a quick PSA reminding people that to use the SQL benchmarks you'll now need to speicfy the pkg/bench package instead of pkg/sql/bench- normally I wouldn't care but the command line invocations for these sql benchmarks are very magic and ./scripts/bench makes it hard to see what you did wrong.


Reviewed 14 of 14 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@knz
Copy link
Contributor Author

knz commented Nov 20, 2017

Thank you!

@knz knz merged commit c0c198b into cockroachdb:master Nov 20, 2017
@knz knz deleted the 20171116-pgbench branch April 27, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants