New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: move end-to-end and KV tests and common test code to a new package sql/tests #20117
Conversation
c4b57a5
to
8d2f07b
Compare
46e1f14
to
67903a7
Compare
67903a7
to
a6e21f1
Compare
07d3517
to
25f036a
Compare
Rebased after merge of #20106. PTAL. |
re: Same question for Reviewed 14 of 15 files at r1, 25 of 27 files at r2, 10 of 10 files at r3, 12 of 12 files at r4. pkg/sql/tests/sqlkv/benchmark_test.go, line 13 at r4 (raw file):
All of our benchmark tests files are called bench_test.go except for this one. pkg/sql/tests/sqlkv/main_test.go, line 1 at r4 (raw file):
2017? Comments from Reviewable |
25f036a
to
a666217
Compare
Merged the commits and put the files in a single package |
a666217
to
c58c048
Compare
Review status: 27 of 36 files reviewed at latest revision, 2 unresolved discussions. pkg/sql/tests/kv_test.go, line 13 at r4 (raw file): Previously, jordanlewis (Jordan Lewis) wrote…
Reverted. pkg/sql/tests/sqlkv/main_test.go, line 1 at r4 (raw file): Previously, jordanlewis (Jordan Lewis) wrote…
Done. Comments from Reviewable |
c58c048
to
1dd4482
Compare
Reviewed 4 of 15 files at r3, 4 of 16 files at r4, 19 of 19 files at r5. Comments from Reviewable |
TFYR! |
Visible changes here:
sql/tests
sql/tests/highlevel
sql/tests/sqlkv