Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: cockroach node status should show when a node is dead #20192

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

pananc
Copy link
Contributor

@pananc pananc commented Nov 21, 2017

related to #19924

@pananc pananc requested a review from a team as a code owner November 21, 2017 11:06
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2017

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz changed the title cli:cockroach node status should show when a node is dead cli: cockroach node status should show when a node is dead Nov 22, 2017
@knz
Copy link
Contributor

knz commented Nov 22, 2017

Hi @pananc! Thank you for looking into this!

:lgtm: but please

  1. insert a space between "cli:" and "cockroach" in your commit message
  2. squash all the commits into one before we can merge this. Thank you!

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@knz
Copy link
Contributor

knz commented Nov 26, 2017

Thank you! Very good work!

@knz knz merged commit 7bc118d into cockroachdb:master Nov 26, 2017
@pananc pananc deleted the 19924 branch November 27, 2017 02:07
@pananc
Copy link
Contributor Author

pananc commented Nov 27, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants