cherrypick-2.0: storage: Don't allow node liveness expiration to move backwards #23122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if the system clock moves backwards while the `cockroach` process is not running, the node will not be able to become live until the clock has caught up with its previous value. If it did, it would be possible to serve stale reads. Release note (bug fix): Guard against stale reads caused by the system clock moving backwards while the `cockroach` process is not running.
|
This change is |
a-robinson
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if the system clock moves backwards while the
cockroachprocess is not running, the node will not be able tobecome live until the clock has caught up with its previous value.
If it did, it would be possible to serve stale reads.
Release note (bug fix): Guard against stale reads caused by the system
clock moving backwards while the
cockroachprocess is not running.