sql: fix DIPAddr serialization issue #26086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Change LGTM. Reviewed 2 of 2 files at r1. Comments from Reviewable |
Correcting `DIPAddr.AmbiguousFormat` to be true, i.e. that type annotations are necessary when serializing the datum (e.g. for DistSQL). Without it, the value is parsed as a string. Release note (bug fix): Fixed an error caused by INET constants in some rare cases.
RaduBerinde
force-pushed
the
ipaddr-serialization
branch
from
0d1e15d
to
55c5749
Compare
|
Indeed, thanks. I conjured up a testcase that failed before. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 25, 2018
26086: sql: fix DIPAddr serialization issue r=RaduBerinde a=RaduBerinde Correcting `DIPAddr.AmbiguousFormat` to be true, i.e. that type annotations are necessary when serializing the datum (e.g. for DistSQL). Without it, the value is parsed as a string. Release note (bug fix): Fixed an error caused by INET constants in some rare cases. Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting
DIPAddr.AmbiguousFormatto be true, i.e. that typeannotations are necessary when serializing the datum (e.g. for
DistSQL). Without it, the value is parsed as a string.
Release note (bug fix): Fixed an error caused by INET constants in
some rare cases.