importccl: fix MYSQLOUTFILE edge cases #26275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
reviewed
Jun 1, 2018
| opts roachpb.MySQLOutfileOptions | ||
| conv rowConverter | ||
| opts roachpb.MySQLOutfileOptions | ||
| debugRow func(tree.Datums) |
There was a problem hiding this comment.
was during debugging. removed.
dt
reviewed
Jun 1, 2018
| } | ||
| for query, res := range tc.query { | ||
| sqlDB.CheckQueryResults(t, query, res) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| t.Run("mysqlout multpile", func(t *testing.T) { |
dt
approved these changes
Jun 1, 2018
Previously, the MYSQLOUTFILE file reader would convert its data to CSV and use the CSV workers to convert it to datums. This worked for most data, but was not able to correctly handle all NULL encodings. To fix this, decouple MYSQLOUTFILE from CSV so that it can parse datums in its own way and thus handle NULLs correctly. This does lose parallelization, but we can come up with ways to do that in the future. As a side effect, this fixes the listed bug, which occurred because the csvRecord field wasn't being correctly initialized since readFile was shadowing the CSV readFile. Fixes #26153 Release note (bug fix): correct NULL handling during IMPORT of MYSQLOUTFILE.
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.