Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importccl: fix MYSQLOUTFILE edge cases #26275

Merged
merged 2 commits into from Jun 1, 2018
Merged

importccl: fix MYSQLOUTFILE edge cases #26275

merged 2 commits into from Jun 1, 2018

Commits on Jun 1, 2018

  1. importccl: don't require \n at EOF in mysqlout during IMPORT 

    Fixes #25876
    @maddyblue
    maddyblue committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    a38fdb5 View commit details
    Browse the repository at this point in the history

  2. importccl: fix edge cases in mysqloutfile reading 

    Previously, the MYSQLOUTFILE file reader would convert its data to
CSV and use the CSV workers to convert it to datums. This worked for
most data, but was not able to correctly handle all NULL encodings.

To fix this, decouple MYSQLOUTFILE from CSV so that it can parse
datums in its own way and thus handle NULLs correctly. This does lose
parallelization, but we can come up with ways to do that in the future.

As a side effect, this fixes the listed bug, which occurred because
the csvRecord field wasn't being correctly initialized since readFile
was shadowing the CSV readFile.

Fixes #26153

Release note (bug fix): correct NULL handling during IMPORT of
MYSQLOUTFILE.
    @maddyblue
    maddyblue committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    fe81c74 View commit details
    Browse the repository at this point in the history