opt: display float costs and stats more accurately #26873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
The costs and stats are not very useful when the values are small
(which tends to happen when there are multi-column constraints).
Switching the display of floats to use `%.9g`. This show us a bunch of
significant digits regardless of the scale while still displaying
integers without a decimal point:
```
Value | %.9g
0 | 0
0.0000000001234 | 1.234e-10
0.001234 | 0.001234
0.1 | 0.1
1 | 1
1.0001 | 1.0001
1234.5678 | 1234.5678
12345678 | 12345678
200000000 | 200000000
```
Release note: None
Release note: None
RaduBerinde
force-pushed
the
display-floats
branch
from
176b946
to
00d38d4
Compare
|
bors r+ |
Canceled (will resume) |
craig bot
pushed a commit
that referenced
this pull request
Jun 21, 2018
26873: opt: display float costs and stats more accurately r=RaduBerinde a=RaduBerinde
The costs and stats are not very useful when the values are small
(which tends to happen when there are multi-column constraints).
Switching the display of floats to use `%.9g`. This show us a bunch of
significant digits regardless of the scale while still displaying
integers without a decimal point:
```
Value | %.9g
0 | 0
0.0000000001234 | 1.234e-10
0.001234 | 0.001234
0.1 | 0.1
1 | 1
1.0001 | 1.0001
1234.5678 | 1234.5678
12345678 | 12345678
200000000 | 200000000
```
Release note: None
Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The costs and stats are not very useful when the values are small
(which tends to happen when there are multi-column constraints).
Switching the display of floats to use
%.9g. This show us a bunch ofsignificant digits regardless of the scale while still displaying
integers without a decimal point:
Release note: None